Fix potential null issue in rawAddPrefix method #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avbdr when you have time, can you please review it? |
|
Thanks for the pull request, @CassianoRafael! This looks like a valuable fix for a potential null issue in the rawAddPrefix method. I appreciate you catching this and taking the time to contribute (especially as a first-time contributor!). The issue @CassianoRafael identified is likely valid. Here's why: PHP Deprecated Warnings: In newer PHP versions, accessing properties of potentially null variables can trigger warnings. The proposed fix with a conditional check avoids this scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a potential issue in the
rawAddPrefixmethod where, if the provided SQL query does not contain keywords like "from", "into", "update", "join", or "describe" (e.g. functions and procedures), the$tablearray would be empty, leading to a PHP deprecated warning in the newer versions.The proposed solution adds a conditional check to ensure that there are table name matches before proceeding with the replacement.